vram-guild / canvas

Shader-Based Minecraft Renderer for Fabric
GNU Lesser General Public License v3.0
416 stars 40 forks source link

Crash at startup when using with Custom Machinery #429

Closed ZZZank closed 1 year ago

ZZZank commented 1 year ago

System Information

Other mods and versions installed

How you triggered the behavior

Logs and screenshots

crash-2023-06-27_19.09.35-client.txt

I have some knowledge about mixin, and I found a cretain part in crash report that's very likely to be the reason: Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @At("INVOKE") on net/minecraft/class_778::custommachinery$getLightEmission with priority 1000 cannot inject into net/minecraft/class_778::method_3374(Lnet/minecraft/class_1920;Lnet/minecraft/class_1087;Lnet/minecraft/class_2680;Lnet/minecraft/class_2338;Lnet/minecraft/class_4587;Lnet/minecraft/class_4588;ZLjava/util/Random;JI)Z merged by grondag.canvas.mixin.MixinModelBlockRenderer with priority 1000 [PREINJECT Applicator Phase -> custommachinery.fabric.mixins.json:ModelBlockRendererMixin from mod custommachinery -> Prepare Injections -> -> redirect$zfh000$custommachinery$getLightEmission(Lnet/minecraft/class_2680;Lnet/minecraft/class_1920;Lnet/minecraft/class_1087;Lnet/minecraft/class_2680;Lnet/minecraft/class_2338;)I -> Prepare]

Also, the same issue : https://github.com/Frinn38/Custom-Machinery/issues/94

supsm commented 1 year ago

Hi, it seems that my pull request #408 for 1.19 (which fixes this issue) has only been merged into 1.18 branch in the latest commit. Could you try compiling it yourself? And @spiralhalo could you consider releasing another 1.18.2 release?

ZZZank commented 1 year ago

Could you try compiling it yourself?

I don't know how to, so I might better just wait for a new release.

supsm commented 1 year ago

New release 18.2.2621 is out, maybe give that a shot

spiralhalo commented 1 year ago

I tested the new release myself. Thanks for the report

On a side note, Custom Machinery has a rendering issue relating to matrix state, but this is confirmed reproducible without Canvas thus is unrelated to Canvas.

Frinn38 commented 1 year ago

@spiralhalo Would you mind giving some infos about this rendering issue of CM, either on the github or the discord ?

supsm commented 1 year ago

@Frinn38 discussion of other issues should be done on canvas or a separate Github issue for better bookkeeping.