search

vranki / ExtPlane

Plugin for X-Plane flight simulator which allows reading and writing simulation properties
138 stars 44 forks source link

Compiled Windows version is missing from releases #74

Open sanderdatema opened 3 years ago

sanderdatema commented 3 years ago

The readme mentions Linux and Windows versions are in the releases. But it's only Linux. Since it's possible to compile for those two systems using Docker, you could have Github Actions do it for you. I know you're looking for developers, but I'm afraid I can't help out with this, though I'll try to look into it.

vranki commented 3 years ago

Yeah, the windows cross-complilation seems to be broken at the moment for some reason. Needs to be studied. Help is welcome as I don't run X-Plane or develop on Windows.

jfjoubert commented 3 years ago

DISCLAIMER: I know very little about QT and Docker and cross-compilation etc... but I found that the Windows xpl was missing due to the DESTDIR = $$PWD line that was commented out in the extplane-server.pro file. I think this resulted in the libextplane-server.a file not being built or something. (like I said I know very little about this stuff :-)) I uncommented the line above and did a build using Docker on Windows and the final build contained both the win.xpl and lin.xpl files. I tested the win.xpl in x-plane and everything seems to be working fine. Unfortunately, I cannot test the lin.xpl from this build as I don't have a Linux setup with x-plane. Just thought it might be helpful to someone.

sanderdatema commented 3 years ago

I uncommented the line above and did a build using Docker on Windows and the final build contained both the win.xpl and lin.xpl files.

Would you be able to create a PR for that?

jfjoubert commented 3 years ago

I have never done anything like that before, but I can give it a try.

sanderdatema commented 3 years ago

You can even go to the file in this repo, press edit and GitHub will guide you through the process (sort of).

Op 26 aug. 2021 om 00:03 heeft jfjoubert @.***> het volgende geschreven:

 I have never done anything like that before, but I can give it a try.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

tannerblair commented 2 years ago

Any updates on this? I would love to use this, but I'm less fond of signing up for an account just so I can compile it.