vrastil / FastSim

Other
0 stars 1 forks source link

Delete .lgtm.yml: LGTM.com will figure things out automatically #36

Closed sj closed 5 years ago

sj commented 5 years ago

Now FastSim is using cmake for its build process, there is no longer any need for an .lgtm.yml file with build instructions for LGTM.com Python and C/C++ analysis.

I've already tested this on the LGTM staging environment: all works! As soon as this PR is merged (and .lgtm.yml is deleted), I can kick off another C/C++ build and results should be in soon.

(full disclosure: I'm part of the team that built LGTM.com)

sj commented 5 years ago

Note that the Python analysis failure in this pull request is due to the fact that the base commit (current master) cannot be analysed. This means that LGTM can't compare the current state of the Python code base to the new state, and therefore can't comment on whether there are any new or fixed alerts in this PR.

sj commented 5 years ago

Thanks for merging. C/C++ analysis is now in progress. As soon as the latest commit in the FastSim repository has been analysed, automated code review for C/C++ code should start straight away (alongside the existing automatic review for Python).