search

vrchat-community / UdonSharp

A compiler for compiling C# to Udon assembly
https://udonsharp.docs.vrchat.com
MIT License
461 stars 50 forks source link

Fix vpmDependency Check #125

Closed Happyrobot33 closed 1 year ago

Happyrobot33 commented 1 year ago

Having a package that requires greater than 3.2.0 of the com.vrchat.worlds package does not actually bump the SDK package, but will still install itself, leading to a broken project since my package requires new features in 3.2.0

Changing to >= will ensure this doesn't happen anymore, and that UdonSharp doesn't block SDK bumps

Original issue made in VCC repo https://github.com/vrchat-community/creator-companion/issues/275

Happyrobot33 commented 1 year ago

Closes Mattshark89/OpenFlight-VRC#26

Happyrobot33 commented 1 year ago

I dont believe that the package version itself needs to be bumped, as long as the live package.json itself gets updated

Happyrobot33 commented 1 year ago

Changed to ^3.1.x. this will allow all minor version releases (Semantic Versioning mandates minor releases are backwards compatible feature updates) and will also allow all patches, but not allow any major version changes