vrchat-community / creator-companion

The Entry Point for Making Things in VRChat
https://vrchat.com/home/download
64 stars 446 forks source link

[BUG] Installing package with >= 3.2.0 com.vrchat.worlds dependency does not bump the SDK #275

Closed Happyrobot33 closed 1 year ago

Happyrobot33 commented 1 year ago

Describe the bug Having a package that requires greater than 3.2.0 of the com.vrchat.worlds package does not actually bump the SDK package, but will still install itself, leading to a broken project since my package requires new features in 3.2.0

To Reproduce Steps to reproduce the behavior:

  1. Have a world project with 3.1.13 of the worlds SDK
  2. Go to this link to add my repo https://mattshark89.github.io/OpenFlight-VRC/?install=true
  3. add the "OpenFlight" package to the repository at version 1.3.0
  4. observe as the SDK versions do not update to 3.2.0

Expected behavior Packages should bump to 3.2.0. This used to work properly, so I don't know what is broke now

VCC Log

UnityProject removing VPM package com.mattshark.openflight at 9:44 PM
Removed package com.mattshark.openflight from project E:\Storage\Personal\Coding\VRChat\OpenFlight End User Testing
Package com.mattshark.openflight removed successfully
Dependency list upgrading com.vrchat.base from 3.1.13 to 3.1.13
Dependency list upgrading com.vrchat.worlds from 3.1.x to 3.1.x
Dependency list upgrading com.vrchat.base from 3.1.13 to 3.1.13
Dependency list upgrading com.vrchat.worlds from 3.1.x to 3.1.x
Looking for Legacy Packages to Upgrade by Scanning Folders within com.mattshark.openflight
Dependency list upgrading com.vrchat.base from 3.1.13 to 3.1.13
Dependency list upgrading com.vrchat.worlds from 3.1.x to 3.1.x
UnityProject removing VPM package com.vrchat.worlds at 9:44 PM
Added package com.mattshark.openflight to project E:\Storage\Personal\Coding\VRChat\OpenFlight End User Testing
Package com.mattshark.openflight@1.3.0 added successfully

Screenshots Before Package Addition: image

After Package Addition: image

package.json

{
  "name": "com.mattshark.openflight",
  "displayName": "OpenFlight",
  "version": "1.3.0",
  "description": "A VRChat flight system that allow all kinds of avatars to fly. https://github.com/Mattshark89/OpenFlight-VRC",
  "bugs" : {
    "url" : "https://github.com/Mattshark89/OpenFlight-VRC/issues"
  },
  "license": "MIT",
  "repository": {
    "type": "git",
    "url": "https://github.com/Mattshark89/OpenFlight-VRC"
  },
  "dependencies": {
    "com.unity.textmeshpro": "2.1.6"
  },
  "gitDependencies": {},
  "vpmDependencies": {
    "com.vrchat.worlds" : ">=3.2.0",
    "com.vrchat.udonsharp" : ">=1.1.7"
  },
  "legacyFolders": {
    "Assets/OpenFlight-VRC" : "e7b9695e841ecee4fbad1eaafeb82bdb"
  },
  "legacyFiles": {},
  "author": {
    "name": "Mattshark89, Happyrobot33"
  }
}

Desktop (please complete the following information):

Happyrobot33 commented 1 year ago

Found the culprit, this isnt directly a VCC issue, but a UdonSharp issue

{
    "name" : "com.vrchat.udonsharp",
    "displayName" : "UdonSharp",
    "version" : "1.1.7",
    "unity" : "2019.4",
    "description" : "A compiler for compiling C# to Udon assembly",
    "author" : {
        "name" : "VRChat",
        "email" : "developer@vrchat.com",
        "url" : "https://github.com/vrchat/packages"
    },
    "vpmDependencies" : {
        "com.vrchat.worlds" : "3.1.x"
    },
    "samples" : [
        {
            "displayName" : "CustomInspectors",
            "description" : "Custom Inspector Example",
            "path" : "Samples~/CustomInspectors"
        },
        {
            "displayName" : "Tutorials",
            "description" : "Tutorials Example",
            "path" : "Samples~/Tutorials"
        }
    ],
    "legacyFolders" : {
        "Assets\\UdonSharp" : "b031f928e5c709b4887f6513084aaa51",
        "Assets\\Gizmos\\UdonSharp" : "6e940dfc89ce4ca41b651e05bc21be6b"
    }
}
Happyrobot33 commented 1 year ago

Closing this issue since it isnt directly related to the VCC being at fault itself