search

vrchat-community / creator-companion

The Entry Point for Making Things in VRChat
https://vrchat.com/home/download
57 stars 410 forks source link

[BUG] Packages relates to Worlds should depends on VRCSDK instead of clientsim #297

Closed anatawa12 closed 12 months ago

anatawa12 commented 1 year ago

Describe the bug

Packages relates to Worlds should depends on VRCSDK instead of clientsim.

To Reproduce

  1. Open Package Maker
  2. Set Related VRChat Package to Worlds
  3. Select some folder and id
  4. Click convert Assets to Package
  5. Generated package.json declares dependency relationship to clientsim

Expected behavior

Generated package.json should declares dependency relationship to VRCSDK instead.

Screenshots

No response

Related Product

vpm-resolver (Package Resolver)

Product Version

0.1.19

OS

Windows 11

Additional context

No response

anatawa12 commented 1 year ago

@momo-the-monster

I'm sorry for pinging.

Recent developer update announces VRCSDK will include ClientSim and UdonSharp in the next release.

I don't know much about how the new (post-2.1.3) VCC will resolve packages but I think this should be fixed in/until the next package resolver so I ping.

momo-the-monster commented 1 year ago

@anatawa12 - it is fine to ping me about this, thank you. I will make sure this is updated with the new release. Also FYI, I just opened an issue to prepare one of your packages for the upcoming SDK changes.

momo-the-monster commented 12 months ago

Fixed in Resolver 0.1.22.