search

vrchat-community / creator-companion

The Entry Point for Making Things in VRChat
https://vrchat.com/home/download
63 stars 442 forks source link

[BUG] removing legacyFiles is not working if legacyFolders is not specified #299

Closed anatawa12 closed 7 months ago

anatawa12 commented 1 year ago

Describe the bug

removing legacyFiles is not working if legacyFolders is not specified

To Reproduce

  1. Add https://anatawa12.github.io/vpm-repo-for-vcc-bug-testing/ to your VCC
  2. Download and add this project to VCC
  3. Open the project with VCC
  4. Add Legacy File with Name or Legacy File With Path

Expected behavior

Assets/legacyFileWithName.txt or Assets/legacyFileWithPath.txt should be removed

Screenshots

No response

Related Product

VCC (VRChat Creator Companion)

Product Version

2.1.1

OS

Windows 11

Additional context

There are no logs like Looking for Legacy Packages to Upgrade by Scanning Folders within <package> when we're installing Legacy File with Name or Legacy File With Path

If we added legacyFolders attribute, Looking for Legacy Packages to Upgrade by Scanning Folders within <package> is shown but because of #281, no files are removed. (you can test with legacyFiles with Name with legacyFolders package from same repository)

anatawa12 commented 1 year ago

I confirmed this issue still exists in 2.1.2

momo-the-monster commented 1 year ago

Thanks! This should be fixed in the next release.

anatawa12 commented 10 months ago

I confirmed this still is a issue in VCC 2.2.2....

momo-the-monster commented 10 months ago

Thank you for your response, much appreciated.

On Wed, Dec 13, 2023, 8:44 PM anatawa12 @.***> wrote:

I confirmed this still is a issue in VCC 2.2.2....

— Reply to this email directly, view it on GitHub https://github.com/vrchat-community/creator-companion/issues/299#issuecomment-1855120605, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFUEYHZMFTVLQX5QLDVVULYJJ7ZBAVCNFSM6AAAAAAYJIGHVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJVGEZDANRQGU . You are receiving this because you were assigned.Message ID: @.***>

anatawa12 commented 8 months ago

bump. this is still a issue in VCC 2.2.5.

orels1 commented 7 months ago

This should be addressed in the 2.3.0 open beta: https://github.com/vrchat-community/creator-companion/releases/tag/2.3.0

orels1 commented 5 months ago

This has been released to live with version 2.3.0: https://vrcpm.vrchat.cloud/vcc/Builds/2.3.0/VRChat_CreatorCompanion_Setup_2.3.0.exe