search

vrchat-community / creator-companion

The Entry Point for Making Things in VRChat
https://vrchat.com/home/download
60 stars 425 forks source link

[BUG] Both UdonSharp and SDK 3.4.0-beta.1 is installed when installing package depends on UdonSharp to project with VRCSDK worlds 3.3.0 #356

Closed anatawa12 closed 11 months ago

anatawa12 commented 1 year ago

Describe the bug

Both UdonSharp and SDK 3.4.0-beta.1 is installed when installing package depends on UdonSharp to project with VRCSDK worlds 3.3.0

To Reproduce

Pattern A: Project without UdonSharp

  1. Create project with VRCSDK 3.3.0
  2. Install package depends on UdonSharp. I use KinelVideoPlayer by https://vpm.niri.la/ or QvPen by https://vpm.ureishi.net/repos.json
  3. UdonSharp and VRCSDK 3.4.0-beta.1 is installed

Pattern B: Project with UdonSharp

  1. Create project with VRCSDK 3.3.0 and UdonSharp
  2. Install package depends on UdonSharp. I use KinelVideoPlayer by https://vpm.niri.la/ or QvPen by https://vpm.ureishi.net/repos.json
  3. VRCSDK 3.4.0-beta.1 is installed and UdonSharp is not removed

Expected behavior

Pattern A UdonSharp should not be installed OR VRCSDK should not upgraded since currently installed version is compatible with packages

Pattern B UdonSharp should be removed OR VRCSDK should not upgraded since currently installed version is compatible with packages

Screenshots

Pattern A

image image image image

Pattern B

image image

Related Product

VCC (VRChat Creator Companion)

Product Version

2.1.3 and 2.1.4

OS

Windows 10

Additional context

I thought this issue is combination of #349 and #350 but still not resolved.

anatawa12 commented 1 year ago

@momo-the-monster Sorry for pinging again. Is this issue under consideration? I think this must be fixed before Worlds 3.4.0 stable release.

anatawa12 commented 1 year ago

@momo-the-monster Sorry for pinging again and again. I think this VCC bug will break project with GUID duplication.

momo-the-monster commented 1 year ago

@anatawa12 we have a fix and we are working on testing it and getting it to release as soon as we can, thank you.

Sayamame-beans commented 12 months ago

I am very confused, but Pattern B seems to reproduce even when updating the SDK manually. This means,

  1. Create project with VRCSDK 3.3.0 and UdonSharp.
  2. Install package depends on UdonSharp.
  3. Update VRCSDK to 3.4.0 manually.
  4. UdonSharp is not removed.

It is an unbelievably fatal problem that legacyPackages does not work even though other packages that depend on UdonSharp just exist and the SDK was simply updated manually (with little influence from other vpmDependencies, etc.). I assure you that this is the cause of the problem that is currently troubling many users.

momo-the-monster commented 11 months ago

Should be fixed now in Creator Companion 2.1.5, thanks for reporting!