vrchat-community / creator-companion

The Entry Point for Making Things in VRChat
https://vrchat.com/home/download
54 stars 372 forks source link

[BUG 2.1.4] VCC claims that a package was installed when it was not #358

Closed bdunderscore closed 5 months ago

bdunderscore commented 9 months ago

Describe the bug

When the VCC fails to extract a package, it still claims in its UI that the package was installed successfully

To Reproduce

  1. Open a file in an installed package in notepad
  2. Attempt to upgrade or downgrade that package

Expected behavior

The VCC should clearly show that an installation error occurred.

Actual behavior: "Package com.vrchat.avatars@3.3.0 added successfully" is shown, but the package is not, in fact, installed.

2023-10-03 19:40:05.136 +09:00 [INF] VRCLibLogger Writing logs to C:\Users\bd\AppData\Local\VRChatCreatorCompanion\Logs\20231003T194005-7baf0f1fdd8d45fbbdcc3553727e1c12-log.txt
2023-10-03 19:40:05.774 +09:00 [INF] Copying new bundled template Avatar
2023-10-03 19:40:05.809 +09:00 [INF] Copying new bundled template Base
2023-10-03 19:40:05.821 +09:00 [INF] Copying new bundled template UdonSharp
2023-10-03 19:40:05.832 +09:00 [INF] Copying new bundled template World
2023-10-03 19:40:35.535 +09:00 [INF] Looking for Legacy Packages to Upgrade by Scanning Folders within com.vrchat.avatars
2023-10-03 19:40:38.645 +09:00 [ERR] Could not extract package C:\Users\bd\AppData\Local\VRChatCreatorCompanion\Repos\com.vrchat.avatars\com.vrchat.avatars-3.3.0.zip: The process cannot access the file 'Tutorial_Robot_Avatar_Dynamics_Demo_v1.fbx' because it is being used by another process.
2023-10-03 19:40:38.654 +09:00 [INF] Looking for Legacy Packages to Upgrade by Scanning Folders within com.vrchat.avatars
2023-10-03 19:40:40.665 +09:00 [INF] Added package com.vrchat.avatars to project C:\Users\bd\unity\modular-avatar
2023-10-03 19:40:40.694 +09:00 [INF] Package com.vrchat.avatars@3.3.0 added successfully

Screenshots

image

Related Product

VCC (VRChat Creator Companion)

Product Version

2.1.4

OS

Windows 11

Additional context

No response

orels1 commented 5 months ago

This behaviour should be improved in 2.2.x VCC. Please let us know if this is still an issue