search

vrchat-community / creator-companion

The Entry Point for Making Things in VRChat
https://vrchat.com/home/download
54 stars 371 forks source link

[BUG] Packages only depends on UdonSharp are not interpreted as for world package when Curated packages are hidden #366

Open Sayamame-beans opened 9 months ago

Sayamame-beans commented 9 months ago

Describe the bug

If we create package for world with UdonSharp using Package Maker, its vpmDependencies includes only udonsharp. VCC interpret that package as for general package when Curated packages are hidden.

To Reproduce

  1. Add community repository which have packages only depends on UdonSharp. This time, I use https://vpm.ureishi.net/repos.json .
  2. Open "Manage Packages" page on some avatar project.
  3. Hide Curated Packages by unselect "Curated" in Built-in Repositories.
  4. QvPen is shown.

Expected behavior

QvPen is not shown.

Screenshots

No response

Related Product

VCC (VRChat Creator Companion)

Product Version

2.1.5

OS

Windows 10

Additional context

I didn't test it but this problem might also be happened on packages only depends on ClientSim, which also made with older Package Maker.

Sayamame-beans commented 9 months ago

Due to unknown factors, this problem may also be happened regardless of whether Curated packages are hidden or not. (Confirmed)

orels1 commented 9 months ago

The VCC is unable to check transient dependencies for the packages that aren't "loaded" (e.g. Unchecked in the UI), because it has no way to load the manifest for them

We should add a special case for packages that depend on official world-only packages like UdonSharp though. Could also potentially load the manifests ignoring the selected repos state too. Thanks for the report