search

vrchat-community / creator-companion

The Entry Point for Making Things in VRChat
https://vrchat.com/home/download
53 stars 357 forks source link

[BUG] Migrating Unity to 2022 changes order of packages added to the project #406

Open anatawa12 opened 6 months ago

anatawa12 commented 6 months ago

Describe the bug

Migrating Unity to 2022 changes order of packages added to the project. This will introduce meaningless huge diff on the vpm-manifest.json.

I assumes it's because VCC removes and then installs VRCSDK and else. I think just upgrading packages is better.

To Reproduce

  1. Create Unity 2019 VCC project
  2. Add some community packages
  3. copy vpm-manifest.json to compare later
  4. Migrate project to Unity 2022
  5. VRCSDK packages are now the later than community packages in vpm-manifest.json, but not on step 3

Expected behavior

Package ordering in vpm-manifest.json should be preserved

Screenshots

No response

Related Product

VCC (VRChat Creator Companion)

Product Version

2.2.2

OS

Windows 11

Additional context

No response

orels1 commented 6 months ago

The full removal was done on purpose, mainly because the new VCC does not remove packages on upgrade anymore, instead they are being moved to temp folder to be able to rollback if something fails (or if there is a locked dll present). The migration process, however, doesn't need a rollback, and instead is built to fail fast if something goes wrong, so full removal was chosen.

The folder with the original SDK is not even copied to the migrated project (if using "Migrate Copy") for the same reason.

We can look into this, but just wanted to mention that