search

vrchat-community / creator-companion

The Entry Point for Making Things in VRChat
https://vrchat.com/home/download
60 stars 425 forks source link

[BUG] Audio Link will be added to projects without Audio Link during unity 2022 migration #434

Closed anatawa12 closed 7 months ago

anatawa12 commented 7 months ago

Describe the bug

Audio Link will be added to projects without Audio Link during unity 2022 migration

Exactly same issue as #407 with different package

To Reproduce

  1. create avatars 2019 project
  2. migrate the project

Expected behavior

Packages not installed before migration must not be installed after migration (unless it's new dependencies of a packages)

Screenshots

No response

Related Product

VCC (VRChat Creator Companion)

Product Version

2.2.4

OS

Windows 11

Additional context

No response

anatawa12 commented 7 months ago

In addition, This warning is shown even if we don't have any (custom) shaders with audiolink

image
orels1 commented 7 months ago

Hmm, odd. There is logic in place to upgrade pre-1.x AL to 1.x AL if it was already in the project, to avoid it requesting to install UdonSharp for people who were using pre 3.4.x SDKs before the migration.

Was able to reproduce, so I'll look into why a project without audio link might report that it has sub 1.x audiolink installed, thanks for the report 👍

Second issue is with AudioLink itself, it seems to fire every single time no matter if you have any shaders in the project or not. Might be worth creating an issue on the AudioLink repository if you think its a bug.

orels1 commented 7 months ago

This is addressed in VCC 2.2.5 that was just released