vrchat-community / creator-companion

The Entry Point for Making Things in VRChat
https://vrchat.com/home/download
64 stars 448 forks source link

[BUG] Several packages versions of upm packages in 2022 template is (still) outdated. #441

Open anatawa12 opened 8 months ago

anatawa12 commented 8 months ago

Describe the bug

Several packages versions of upm packages in 2022 template is (still) outdated.

Some unitypackage can cause problem because of this version difference.

Related: https://feedback.vrchat.com/bug-reports/p/bug-vcc-222-creates-unity-2022-with-outdated-packages

To Reproduce

  1. Install the VCC
  2. Create Unity 2022 project with unity hub
  3. Migrating Unity 2019 project to 2022 with VCC
  4. Compare Packages/manifest.json in Project Templates by VCC, New project with Unity Hub, and Migrated project

Expected behavior

Specified versions in manifest.json is same between Packages/manifest.json in Project Templates by VCC, and New project with Unity Hub or Migrated project.

Screenshots

--- template-manifest-formatted.json    2024-03-05 01:08:40
+++ Migrated-manifest.json  2024-03-05 01:02:22
@@ -1,10 +1,12 @@
 {
-  "dependencies" : {
-    "com.unity.ide.rider": "3.0.26",
-    "com.unity.ide.visualstudio": "2.0.22",
+  "dependencies": {
+    "com.unity.ai.navigation": "1.1.4",
+    "com.unity.collab-proxy": "2.0.5",
+    "com.unity.ide.rider": "3.0.24",
+    "com.unity.ide.visualstudio": "2.0.18",
     "com.unity.ide.vscode": "1.2.5",
-    "com.unity.test-framework": "1.1.29",
-    "com.unity.textmeshpro": "2.1.6",
+    "com.unity.test-framework": "1.1.33",
+    "com.unity.textmeshpro": "3.0.6",
     "com.unity.timeline": "1.7.5",
     "com.unity.ugui": "1.0.0",
     "com.unity.modules.ai": "1.0.0",
--- template-manifest-formatted.json    2024-03-05 01:08:40
+++ new-2022-project-by-unity-hub-manifest.json 2024-03-05 01:08:32
@@ -1,12 +1,11 @@
 {
-  "dependencies" : {
-    "com.unity.ide.rider": "3.0.26",
-    "com.unity.ide.visualstudio": "2.0.22",
-    "com.unity.ide.vscode": "1.2.5",
-    "com.unity.test-framework": "1.1.29",
-    "com.unity.textmeshpro": "2.1.6",
+  "dependencies": {
+    "com.unity.collab-proxy": "2.3.1",
+    "com.unity.feature.development": "1.0.1",
+    "com.unity.textmeshpro": "3.0.6",
     "com.unity.timeline": "1.7.5",
     "com.unity.ugui": "1.0.0",
+    "com.unity.visualscripting": "1.8.0",
     "com.unity.modules.ai": "1.0.0",
     "com.unity.modules.androidjni": "1.0.0",
     "com.unity.modules.animation": "1.0.0",

Related Product

VCC (VRChat Creator Companion)

Product Version

2.2.5

OS

Windows 11

Additional context

No response

orels1 commented 8 months ago

The package versions used are geared towards matching versions in the client, instead of matching the ones provided with the fresh Unity Hub project creation, as those do differ a little bit last time I checked and the parity with the client is the goal here.

However, I think some things do need to be updated (at least text mesh pro), so we'll take a look

anatawa12 commented 8 months ago

Having difference between template and migrated caused compilation error about my friends tool so I think it's better to have same versions between template and migrated. I think it's not as big problem as difference between template and migrated that having difference between new project from unity hub and template.