vrchat-community / creator-companion

The Entry Point for Making Things in VRChat
https://vrchat.com/home/download
53 stars 357 forks source link

[FEATURE] Please use LF on Windows since LF is used widely in Unity on Windows #442

Open anatawa12 opened 3 months ago

anatawa12 commented 3 months ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

When I started to write .gitattribute file for my new unity project, I found only Packages/vpm-manifest.json is using CRLF on windows, other unity-related files including Packages/manifest.json, Packages/package-lock.json, and all unityyaml files so I have to write exception eol=lf for Packages/manifest.json.

Describe the solution you'd like A clear and concise description of what you want to happen.

Use LF for Packages/vpm-manifest.json as unity files does.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

With TextWriter.NewLine, we can change eol for json file with Newtonsoft.Json.

I didn't use unity on windows for long so I did not notice this.