search

vrchat-community / creator-companion

The Entry Point for Making Things in VRChat
https://vrchat.com/home/download
60 stars 424 forks source link

[BUG] [2.3.0-beta.2] LegacyFolders Function no longer works with Poiyomi Shaders VPM Repo #467

Closed BluWizard10 closed 5 months ago

BluWizard10 commented 5 months ago

Describe the bug

In the current LIVE version of the VCC, the package.json correctly removes the Assets\\_PoiyomiShaders folder as specified in Poiyomi's VPM Repo.

On the Beta VCC, this no longer functions as it should.

The VPM Repository in question: https://poiyomi.github.io/vpm/

Was there a change made that made this no longer function?

To Reproduce

  1. Use a project that has Assets/_PoiyomiShaders folder in it.
  2. Attempt to add Poiyomi Toon Shader to your project through the VCC Beta.
  3. Watch the Logs.
  4. There should be NO messages saying "Will remove x folder"

Expected behavior

The Logs should report a "Will remove x folder" Log entry detailing that the legacyFolder was successfully removed.

Screenshots

No response

Related Product

VCC (VRChat Creator Companion)

Product Version

2.3.0-beta.2

OS

Windows 10

Additional context

No response

BluWizard10 commented 5 months ago

After discussing with orels1 a bit, it seems this is due to the technical changes in the VCC Beta 2.3.x (which are good) but at the same time affects packages that never used GUIDs for some reason.

I'm cross-referencing a related thread: https://github.com/poiyomi/PoiyomiToonShader/pull/62

BluWizard10 commented 5 months ago

Closing Issue because the GUID behavior change is being reverted. See poiyomi/PoiyomiToonShader#62#issuecomment-2078325534