search

vrchat-community / creator-companion

The Entry Point for Making Things in VRChat
https://vrchat.com/home/download
60 stars 423 forks source link

[BUG] adding package with legacypackages will not remove package #480

Open anatawa12 opened 4 months ago

anatawa12 commented 4 months ago

Describe the bug

Adding package with legacypackages will not remove package

I found this while investigating vrc-get/vrc-get#952. sorry for late bug reports

To Reproduce

  1. create VRChat worlds 2019 project
  2. downgrade VRCSDK to 3.3.0
  3. add UdonSharp to the project
  4. Upgrade VRCSDK 3.4.x

Expected behavior

udonsharp is removed from dependencies block in vpm-manifest.json

Actual behavior udonsharp is removed from locked but not removed from dependencies block

Screenshots

No response

Related Product

VCC (VRChat Creator Companion)

Product Version

2.3.0

OS

Windows 11

Additional context

Screenshot 2024-05-12 at 21 29 28
orels1 commented 4 months ago

I've seen this one pop up in user reports but without repros, so thanks for the repro steps!

I think resolving might actually clean it up, but it really should just remove it outright.