search

vrchat-community / creator-companion

The Entry Point for Making Things in VRChat
https://vrchat.com/home/download
64 stars 448 forks source link

[BUG] Detected version name of unity 2018 will be incorrect and VCC fails to open project with Unity 2018 #491

Open anatawa12 opened 5 months ago

anatawa12 commented 5 months ago

Describe the bug

Detected version name of unity 2018 will be incorrect.

This will make VCC impossible to open unity 2018 project with VCC.

To Reproduce

Pattern 1: Unity 2018.4.29f1 become 2018.4.29

  1. Install Unity 2018.4.29f1 with Unity Hub https://unity.com/releases/editor/whats-new/2018.4.29
  2. Open VCC
  3. Open Settings and Click View All Installed Versions
  4. We'll see Unity 2018.4.29f1 is regonized as 2018.4.29 <= problem
  5. Add Project for Unity 2018.4.29f1 to VCC
  6. Click Open Unity
  7. VCC will suggest us to install 2018.4.29f1 we already have though <= problem

Pattern 2: Unity 2018.4.31f1 become 2018.4

  1. Install Unity 2018.4.31f1 with Unity Hub https://unity.com/releases/editor/whats-new/2018.4.31
  2. Open VCC
  3. Open Settings and Click View All Installed Versions
  4. We'll see Unity 2018.4.31f1 is regonized as 2018.4.29 <= problem
  5. Add Project for Unity 2018.4.31f1 to VCC
  6. Click Open Unity
  7. VCC will suggest us to install 2018.4.31f1 we already have though <= problem

Expected behavior

VCC Should regonize Unity 2018.4.29f1 as Unity 2018.4.29f1 and Unity 2018.4.31f1 as Unity 2018.4.31f1.

Screenshots

Screenshot 2024-05-29 at 14 16 20 image image

Related Product

VCC (VRChat Creator Companion)

Product Version

2.

OS

Windows 11

Additional context

I found this bug while investigating vrc-get/vrc-get#1023 and vrc-get/vrc-get#1031.

orels1 commented 5 months ago

Interesting. I will see if I can repro, because .29f1 is what I initially tested this functionality with 🤔