search

vrchat-community / osc

Files and Info on using OSC to communicate with VRChat
MIT License
234 stars 5 forks source link

Avatars with no OSC Mapping fail to initialize if OSC is enabled #25

Closed NarryG closed 2 years ago

NarryG commented 2 years ago

Describe the bug If an avatar does not have an OSC mapping, the avatar will fail to initialize if OSC is enabled.

To Reproduce Steps to reproduce the behavior:

  1. Follow steps in #24
  2. Enable OSC in-game
  3. Load an avatar
  4. The avatar will be stuck in the reference pose and an exception will exist in the log

Alternate steps if unable to reproduce #24

  1. Restrict access to the mappings folder by overriding file permissions
  2. Enable OSC in-game
  3. Load an avatar
  4. The avatar will be stuck in the reference pose and an exception will exist in the log.

Expected behavior Avatars without mappings should throw an error specific to OSC, not completely fail to load, as this masks the actual bug. If VRC chooses this offensive programming behavior instead of a defensive failure moving the exception closer to the cause, this can be discarded.

Screenshots Exception (when performed with steps in #24): image

Info (please complete the following information):

Additional context See #24 for how an avatar without a mapping can be created without external interference.

momo-the-monster commented 2 years ago

Fixed in Next Release! If an avatar's config cannot be saved or loaded from disk, it will log a warning and move along anyway.