search

vrchat-community / package-list-action

Example Action for VPM Package Repo
Other
2 stars 25 forks source link

feat: include packages from other vpm repository #23

Open anatawa12 opened 12 months ago

anatawa12 commented 12 months ago

Closes #21

Spokeek commented 11 months ago

I have a thought about this, as we base ourselves on package ids, those can have some vpm dependencies.

Do we want to track and automatically add those dependencies as well ?

Spokeek commented 11 months ago

Also, after taking time to try, it works great, but i would add some debug logs to follow what we have for other packages.

As an example, when fetching a package from github, we receive the next two logs

  17:30:14 [INF] Looking at https://github.com/Spokeek/goloco/releases/download/1.7.91/gogoloco-1.7.91.zip
  17:30:14 [INF] Found gogoloco (gogoloco) 1.7.91, adding to listing.

As we already have the 17:30:29 [INF] Downloading from vpm repository at the begining, maybe add logs to confirm when we actually add the manifests.

For the rest, it's all good to me.

anatawa12 commented 11 months ago

Do we want to track and automatically add those dependencies as well ?

I think no. I think it's good to have some check and exclusion (or error) for missing dependencies in the repository but I don't think including packages non explicitly is not good.

maybe add logs to confirm when we actually add the manifests.

I think it's good. I'll add that.