Open silentwasd opened 2 years ago
Thank you for this discovery
@silentwasd I moved this issue to the specification
repo, because I thought favorites
was incorrectly marked as required, but it's not...
So there is a different issue here. It might be that this was fixed some time ago, but the C# SDK is currently having problem generating. Would you have time to please look at it? https://github.com/vrchatapi/vrchatapi-csharp Otherwise I'll look at it when I have time.
Kind of unrelated, but I still have to manually modify the generated dart code to fix an issue with the instances field on the world object
@Rexios80 What is it you're having to fix?
Old generated code that works:
BuiltList<BuiltList<JsonObject>>? get instances;
New generated code that doesn't:
BuiltList<BuiltList<JsonObject?>>? get instances;
The exception:
Unhandled exception:
DioError [DioErrorType.other]: Deserializing '[id, wrld_4cf554b4-430c-4f8f-b53e-1f294eed230b, name, The Black Cat, descript...' to 'World' failed due to: Deserializing '[[03613~region(use), 15], [15327, 16], [14615, 16], [01549~region(use), 16], ...' to 'BuiltList<BuiltList<JsonObject?>>' failed due to: Deserializing '[03613~region(use), 15]' to 'BuiltList<JsonObject?>' failed due to: Bad state: No builder factory for BuiltList<JsonObject?>. Fix by adding one, see SerializersBuilder.addBuilderFactory.
Except there is a builder factory for BuiltList<JsonObject?>
in serializers.g.dart
:
..addBuilderFactory(
const FullType(BuiltList, const [
const FullType(
BuiltList, const [const FullType.nullable(JsonObject)])
]),
() => new ListBuilder<BuiltList<JsonObject?>>())
This seems outdated. I'm now getting a favorites
Property:
https://vrchat.com/api/1/worlds?sort=relevance&fuzzy=true&search=[Hotpocket]%27s+Hideout&n=12
I'm just searching with sort "name", count "50" and offset "300". Result of that request is null. So I was get http response and see, that element with index 6 not have "favorites" property. I think this is problem, why result is null.
Normal world:
Problem world: