vrchatapi / vrchatapi-csharp

🟣VRChat API Library for C#
https://www.nuget.org/packages/VRChat.API
MIT License
54 stars 12 forks source link

GetWorldInstanceWithHttpInfoAsync fails with group instance id's; due to encoding. #16

Closed MistressPlague closed 2 weeks ago

MistressPlague commented 1 year ago

Due to the ~'s in the URL that vrc api depends on, it fails completely as they get blindly encoded.

ariesclark commented 1 year ago

Can you demonstrate which URLs and what errors you encounter?

MistressPlague commented 1 year ago

So, I solved it. In apiclient, PathParameters needs the encode argument set to false. VRCApi always receives them non-encoded.

MistressPlague commented 1 year ago

https://github.com/vrchatapi/vrchatapi-csharp/blob/b94dfcfe7d6f5591ef93aca5bc04813793914204/src/VRChat.API/Client/ApiClient.cs#L295 needs , false at the end of the args.

jellejurre commented 2 weeks ago

Fixed when #23 was merged