search

vrctxl / VideoTXL

Sync and local video players for VRChat with design consideration for events.
MIT License
87 stars 3 forks source link

Latest VRC SDK Update seems to break the player #8

Closed vesturo closed 1 year ago

vesturo commented 1 year ago

Hey Texel, The latest update ( 3.1.11 ) always breaks the SendCustomNetworkEvent in your Player as it now requires 3 values instead of 2. Just wanted to give you a headsup :)

How to reproduce:

Code that breaks: SyncPlayer line 200

public void _InitCheck() { if (!_initDeserialize) { DebugLog("Deserialize not received in reasonable time"); SendCustomNetworkEvent(VRC.Udon.Common.Interfaces.NetworkEventTarget.Owner, "RequestOwnerSync"); } }

vesturo commented 1 year ago

oh and just to make sure: the packages that got an update are:

  1. "com.vrchat.base" = 3.1.11
  2. "com.vrchat.worlds" = 3.1.11
  3. "com.vrchat.udonsharp" = 1.1.7
jaquadro commented 1 year ago

I've been working on the latest SDK and haven't noticed a change. I followed your steps on a new project to double-check but I can't find any version of SendCustomNetworkEvent that takes 3 parameters. Maybe you could provide a screenshot of the error message or snippet from UdonSharpBehaviour.cs?