vrcx-team / VRCX

Friendship management tool for VRChat
MIT License
878 stars 164 forks source link

[Bug] Arrow direction broken after "fix" in Material UI #788

Open CeezusCrisp opened 1 month ago

CeezusCrisp commented 1 month ago

Describe the bug Arrow direction only points to the right now regardless of whether menu is expanded or collapsed. Current design does not follow Material UI design and now doesn't make sense.

To Reproduce Present in dropdown menus such as online, feed, etc.

Expected behavior Previous behavior was correct to how Material UI's "Collapsible Table" should be designed. Arrow should point down when collapsed, point up when expanded. Screenshot 2024-05-15 180301 Screenshot 2024-05-15 180312

Screenshots image

What version you are running Version 2024.05.09

Myrkie commented 1 month ago

The UI is a massive mess and uses a component library, so changing anything in one place can affect other places, in this case a lot of the program uses incorrect drop downs in the component library which result in this effect, fixing it properly without a jank fix through CSS would require actually modifying the other themes to also use the correct components, as changing the components in the pugs would also modify it for the other themes which DO work fine though in a jank way. this is an example case of changing 1 item resulting in changing other unrelated ones. Ive been trying to slowly patch work the material theme into a use able state but the original maintainer has mostly left the project to work on localization, there are several more important issues to fix before this one that ive had no luck with (example being long user names break user selection dialog)