search

vre-hub / reana-jupyterlab-extension

Reana JupyterLab plugin
Apache License 2.0
1 stars 0 forks source link

[Frontend] - Develop Login tab #6

Closed garciagenrique closed 1 month ago

garciagenrique commented 1 month ago

Would allow connecting with the REANA-VRE service.

Connect in the same way as Reana does: by specifying the reana server url and the reana access token

rubenperezm commented 1 month ago

Would it be necessary to keep the server name and the access token after refreshing the page?

garciagenrique commented 1 month ago

Would it be necessary to keep the server name and the access token after refreshing the page?

I would say yes, but maybe i'm missing something. In the same way that when you reload the page of the jupyter session, you return to the same "kernel/terminal" state, I would think the same of the REANA vars.

Which is the error/issue that you are facing ?

rubenperezm commented 1 month ago

I'm not facing any errors at all, I just wanted to know if I should implement this or not. Understood ;)

rubenperezm commented 1 month ago

Would it be necessary to keep the server name and the access token after refreshing the page?

It is implemented now (57339b8850869e606f6035332bd9dfd5b6cffb78). I am using a file under the /tmp directory in the server to store the credentials. It is overwritten when the user tries to connect with other credentials, and is read after refreshing the page (if the file does not exist, the values are empty strings).

I want to change a few things before pushing the "final" version of the login tab (use a Spinner while fetching the credentials from the server and improve the behaviour in general).