Hello, I found a performance issue in the definition of marigin_loss, nabu/neuralnetworks/trainers/loss_functions.py, tf.to_float(targets) will be created repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.
Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.
Hello, I found a performance issue in the definition of
marigin_loss
, nabu/neuralnetworks/trainers/loss_functions.py,tf.to_float(targets)
will be created repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.