vrenkens / nabu

Code for end-to-end ASR with neural networks, build with TensorFlow
MIT License
108 stars 43 forks source link

Performance issue in the definition of marigin_loss, nabu/neuralnetworks/trainers/loss_functions.py(P1) #60

Open DLPerf opened 3 years ago

DLPerf commented 3 years ago

Hello, I found a performance issue in the definition of marigin_loss, nabu/neuralnetworks/trainers/loss_functions.py, tf.to_float(targets) will be created repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.