search

vrickey123 / LeapForWaniKani

Android app for WaniKani (MVVM + Coroutines). Available on Google Play.
GNU General Public License v3.0
10 stars 3 forks source link

Erroneous push notifications about pending lessons #34

Open otsukaresamurai opened 3 years ago

otsukaresamurai commented 3 years ago

I very frequently receive push notifications that I have pending lessons that don't actually exist. If this isn't already a known issue for other reasons, my guess is it may be due to the fact that I reset my level backwards when resuming WK after a long absence.

vrickey123 commented 3 years ago

@otsukaresamurai Thanks for the heads up. There were a few notification fixes in the past, so I just want to clarify a few things:

The notification function should request your latest status every day, so it should send you a notification based on your current status. Resets are an edge case, but if it is working as expected then hopefully it wouldn't cause an issue.

On a side note: if you are frequently doing Lessons on another platform like the WK Desktop Website as soon as they become available and also have an aggressive notification frequency set hourly, then it's possible it could get out of sync. The reason why is because the app doesn't get a push from WK but instead asks WK in the background for updates. This background update is limited by the Android OS for battery optimization and we can't control when it happens. This is the potential grey area for heavy users.

otsukaresamurai commented 3 years ago

I'm on the current version. I do use other devices sometimes but primarily this one. The notification pops up roughly hourly and if I open the app it shows 0 lessons and 0 reviews. If I tap the push notification itself it takes me directly to the lessons page in WK with 0 lessons pending.

On Sat, Oct 31, 2020, 10:18 vrickey123 notifications@github.com wrote:

@otsukaresamurai https://github.com/otsukaresamurai Thanks for the heads up. There were a few notification fixes in the past, so I just want to clarify a few things:

  • Are you on the latest version? v1.2.1 should be listed at the bottom of the nav drawer when you open the hamburger icon.
  • Is this accurate? (1) Receive notification indicating lessons are available (2) Open app (3) Lessons card has 0 count or clicking Lessons card leads you to the WK Lessons Website with no lessons

The notification function should request your latest status every day, so it should send you a notification based on your current status. Resets are an edge case, but if it is working as expected then hopefully it wouldn't cause an issue.

On a side note: if you are frequently doing Lessons on another platform like the WK Desktop Website as soon as they become available and also have an aggressive notification frequency set hourly, then it's possible it could get out of sync. The reason why is because the app doesn't get a push from WK but instead asks WK in the background for updates. This background update is limited by the Android OS for battery optimization and we can't control when it happens. This is the potential grey area for heavy users.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vrickey123/LeapForWaniKani/issues/34#issuecomment-719955138, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHRKOMXGSPUPDOSYCZR32J3SNQ2EPANCNFSM4TFTZO5Q .

vrickey123 commented 3 years ago

Thanks. It sounds like their might be a bug where if lessons or reviews are completely zero's out, a notification still might be sent. I'll take a look at the WK responses in this situation and if it's a quick fix, I'll address it.