search

vrillusions / permit-cookies

Firefox extension that quickly lets you adjust the cookie permissions for a site.
https://addons.mozilla.org/en-US/firefox/addon/permit-cookies-2/
Other
7 stars 4 forks source link

Change the API for nsIPermissionManager::Remove() to accept a URI instead of a string #17

Closed vrillusions closed 9 years ago

vrillusions commented 9 years ago

Submitted by "Joe G" via contact form on site. Plugin will break in FF 42 due to an api change. This will require supporting both versions for a while.

References:

vrillusions commented 9 years ago

From a comment on mozilla page here's another reference topic: http://forums.mozillazine.org/viewtopic.php?f=23&t=2953451

vrillusions commented 9 years ago

OK I got a nightly version running. This is v43 but the exact error that is logged:

NS_ERROR_XPC_BAD_CONVERT_JS: Could not convert JavaScript argument arg 0 [nsIPermissionManager.remove] pcookie.js:220:0
vrillusions commented 9 years ago

Well I've been working on this and noticed something that may break things but I havent' tested it yet:

Right now cookies are permitted based solely on domain name, like github.com. This whole nsIURL thing means all domains in there need to have a protocol set for it, like http://github.com. I haven't tested if when firefox sees a list of just domains it will auto add the protocol to it. Then the issue comes up that if it makes it http://github.com but since they use TLS everywhere it will compare that to https://github.com and don't think it matches. Mostly this is just FMR when compiling release notes. Should be able to have an updated release candidate out by end of this weekend.

(edit) Copied my permissions db from main profile. Turns out how they fix that is duplicate every permission with both http and https. Meaning if you previously allowed github.com then with version 42 it will convert it to both http://github.com and https://github.com