vrimar / construct-ui

A Mithril.js UI library
https://vrimar.github.io/construct-ui
MIT License
287 stars 24 forks source link

Drawer example code not working for onClose #21

Closed jobqueue closed 4 years ago

jobqueue commented 4 years ago

I tried example code here: Example

The only changes I made are changing the import statement to

import './node_modules/construct-ui/lib/index.css'
import {
    Button,
    Icons,
    CustomSelect,
    ButtonGroup,
    Drawer,
    Dialog,
    SelectList,
    ListItem,
    FocusManager
  } from 'construct-ui';

The onClose() is reached in the drawer, but isDrawerOpen = false; is not closing the Drawer. Wondering if I missed something from Mithril.js to make this work.

Version information
    "construct-ui": "^0.2.3",
    "mithril": "^2.0.4"
vrimar commented 4 years ago

The master branch targets Mithril@1.x while the 1.0 branch targets Mithril@2.x. Can you provide a reproducible example?