construct-ui Grid is actually... flex?

vrimar / construct-ui

A Mithril.js UI library

https://vrimar.github.io/construct-ui

MIT License

287 stars 23 forks source link

Closed angrytongan closed 4 years ago

angrytongan commented 4 years ago

Construct-ui Grid actually creates CSS using flex:

Screen Shot 2020-04-25 at 6 49 10 pm

Uh, not sure what to say about this one...? Should it be called Flex instead? Or change Grid to use CSS display: grid? Leave as is?

Breaking change, here as a note. 1.0.0 branch.

kczx3 commented 4 years ago

Why does it matter what it’s called? It’s just a name that creates abstraction over the implementation.

vrimar commented 4 years ago

As @kczx3 mentioned, it's just an abstraction similar to bootstrap, semantic-ui, ant-design etc. which all use display:flex.