search

vrimar / construct-ui

A Mithril.js UI library
https://vrimar.github.io/construct-ui
MIT License
287 stars 23 forks source link

itemListRender attribute on SelectList component has no effect #31

Open raykyri opened 4 years ago

raykyri commented 4 years ago

It is supposed to be used to render the SelectList's .cui-list, but never gets called when it is specified.

(Originally reported by @gdjohnson, and I was able to replicate.)

vrimar commented 4 years ago

Looks like I documented the itemListRender attribute but... completely forgot to implement the logic haha. I'll need to take a better look to properly account for list keyboard interactions.

jdiderik commented 4 years ago

edit: Nevermind, I used m.render, changed to m.mount and now all is well :-)

~~Can it be that this is the reason I cannot get the multi selectlist to work? I do not use typescript and have therefore build and included the min.js and although passing items to render, they never get drawn when clicking on the selectlist (which does show up) I tried to replicate the example by making a class for it to include within my application.~~

Here is my component code gist