search

vrimar / construct-ui

A Mithril.js UI library
https://vrimar.github.io/construct-ui
MIT License
287 stars 23 forks source link

Consider dropping enquirejs #41

Closed panoply closed 3 years ago

panoply commented 3 years ago

Grid depends upon enquirejs, maybe consider an alternative. I've had great success with ssm for previous projects or rolling a simple stylesheet generated with BSS could suffice too. The way in which Enquire pulls in and provides cjs support results in minor headaches when rolling with bundlers like Rollup.

Thanks for all the work on this vrimar, really is a beautiful addition to the mithril nexus. Would love to be able to buy you a coffee/beer/vodka. Thanks.

vrimar commented 3 years ago

I've replaced enquirejs with ssm in v0.2.9 and added the ability to override the defaults. I appreciate your interest in the library and thanks for the offer haha!

vrimar commented 3 years ago

I just realized I'm importing the minified version of ssm, import ssm from 'simplestatemanager/dist/ssm.min.js';. Would this cause issues with rollup?

panoply commented 3 years ago

Will be no problems at all. Thanks a ton for the quick fix. I'll be leveraging construct UI heavily on an upcoming project, very excited to go deeper in the codebase.