1 - I think using strict mode would be better for avoiding errors.
2 - I didn't catch this in the PR you made, but just exporting getConfig in config_reader.js doesn't allow the tests to individually test the functions. if there's another way around that, I'm down for it. But I can't think of another way.
vritant24
commented
6 years ago
1 - I think using strict mode would be better for avoiding errors. 2 - I didn't catch this in the PR you made, but just exporting
getConfiginconfig_reader.jsdoesn't allow the tests to individually test the functions. if there's another way around that, I'm down for it. But I can't think of another way.