[Bugfix] TextInput and Textarea spacings - Githubissues

vrk-kpa / suomifi-ui-components

Suomi.fi-styleguide in React components

Other

30 stars 15 forks source link

[Bugfix] TextInput and Textarea spacings #835

Closed LJKaski closed 8 months ago

LJKaski commented 8 months ago

Description

There were a few issues with the spacings of TextInput and Textarea, which this PR fixes:

TextInput had an implicit line-height set at the top level, which caused the component to take up unnecessary extra space
There was a 1px difference between status text and character counter top margins
Textarea label was lacking the correct bottom margin

Motivation and Context

The line height issue was reported by a developer, and the other issues were noticed during the fixing and testing of that change.

How Has This Been Tested?

Tested by running locally on styleguidist on chrome and inspecting the rendered styles and visual representations.

Release notes

TextInput

Breaking change: Remove redundant root level font styles and set line-height to 0 on top level.
Breaking change: Increase character counter top margin by 1px
Textarea
Breaking change: Set the correct bottom margin for the label
Breaking change: Increase character counter top margin by 1px