search

vrk-kpa / xroad-joint-development

Unmaintained repository. Development moved to: https://github.com/nordic-institute/X-Road-development
19 stars 8 forks source link

As a Product Owner I want that the when creating an HTTP connection for fetching the OCSP responses, setReadTimeout is used to avoid possible jam situation #104

Closed hanhaka closed 7 years ago

hanhaka commented 7 years ago

Affected components: OcspClient Affected documentation: - Estimated delivery: Q1/2017 External reference: https://jira.csc.fi/browse/PVAYLADEV-656

Problem HttpUrlConnection -function may get jammed in situation when an HTTP connection is created and the connection is established but the data is never transferred due to f.ex. network problems. By setting the readTimeout for HttpUrlConnection -function will clear this jam situation.

For more information, see the problematic source code lines by clicking the follow link: https://github.com/vrk-kpa/xroad-public/blob/33e862e698083f3a769490f111ea5a00f7ebe8da/src/signer/src/main/java/ee/ria/xroad/signer/certmanager/OcspClient.java#L176-L182

Acceptance criteria

hanhaka commented 7 years ago

Approved by working group to be fixed.

hanhaka commented 7 years ago

Commited to XM/develop (finnish-6.9.2 pull request). Will be available in 6.9.2 release.