search

vrk-kpa / xroad-joint-development

Unmaintained repository. Development moved to: https://github.com/nordic-institute/X-Road-development
19 stars 8 forks source link

Bug: messages are held in security server during timestamping #152

Closed VitaliStupin closed 6 years ago

VitaliStupin commented 7 years ago

Affected components: - Affected documentation: - Estimated delivery: - External reference: -

Problem During load tests it was noticed that periodically message exchange stops as if timestamping would lock messagelog table and prevent new messages to be sent.

To illustrate the problem. Chart with timestamps (timestamping made once a minute on each of two security servers): withtimestamps

Chart without timestamps: withouttimestamps

Acceptance criteria

hanhaka commented 7 years ago

This same behavior is also seen during performance testing made by Palveluväylä testing team. Results are similar as shown above (there are occasional 'peaks' in response times). This bug is related how the time-stamping is done. Current time-stamping implementation is not correctly supporting the parallel execution of code but is working more or less in a serialized way.

Partial index related to time-stamping (see https://github.com/vrk-kpa/xroad-joint-development/issues/120 ) is slightly improving the functionality but not is the completely solution. Implementation of time-stamping should be refactored/redesigned to support parallel operations.

VitaliStupin commented 6 years ago

Fixed in 6.17.0