vrk-kpa / xroad-joint-development

Unmaintained repository. Development moved to: https://github.com/nordic-institute/X-Road-development
19 stars 8 forks source link

As a Security Server Administrator I want that _restore_xroad.sh script restarts only listed services so that only valid X-Road services are restarted after backup restore process #161

Closed hanhaka closed 6 years ago

hanhaka commented 7 years ago

Affected components: Affected documentation: ug-ss_x-road_6_security_server_user_guide.md Estimated delivery: Q2/2017 External reference: https://jira.csc.fi/browse/PVAYLADEV-772

Problem Script _restore_xroad.sh will be executed when the backup is restored. This script restarts X-Road related services after the backup restore process is finished. The services that are restarted by the system are selected by grepping the service names using 'xroad' and 'xtee55' words. For more information about the code, see: https://github.com/ria-ee/X-Road/blob/develop/src/packages/xroad/common/usr/share/xroad/scripts/_restore_xroad.sh/#L64-L78

Grepping the names is a kind of bad way to do service restarting because there might be for example X-Road additional addon service that is using very same prefix and that service might not be restart automatically. It would be better that there is a constant list of services in _restore_xroad.sh script that are restarted by the system.

Acceptance criteria

hanhaka commented 7 years ago

Note that optional add-ons like operational monitoring might also need restarting so they must not be ignored when changing the functionality of this script.

hanhaka commented 6 years ago

Fixed in 6.16.0, https://github.com/ria-ee/X-Road/pull/61