vrk-kpa / xroad-joint-development

Unmaintained repository. Development moved to: https://github.com/nordic-institute/X-Road-development
19 stars 8 forks source link

As a Product Owner I want Identifying Entities values are restricted by size and characters allowed #171

Closed ToomasMolder closed 6 years ago

ToomasMolder commented 7 years ago

Affected components: - Affected documentation: X-Road: Message Protocol v4.0 Estimated delivery: - External reference: https://jira.ria.ee/browse/RK-12409

Problem XRoadIdentifierType elements are defined as type="xs:string" without additional technical suggestions or technical restrictions (size/length, allowed/denied characters, restricted keywords), which creates misunderstandings and possible security issues both in X-Road core and in side systems.

XRoadIdentifierType elements are xRoadInstance, memberClass, memberCode, subsystemCode, serviceCode, serviceVersion, they are significant entities in the X-Road system, have to be globally unique identifiers. They are used by unique addressing of X-Road queries within core system (message transport, proxy etc). They are also widely in use by pre-side-systems like RIHA (in EE), probably also TUHA (FI) while registering X-Road members, subsystems and services. They are also widely in use by after-side-systems like environmental and operational monitoring, logging, anomalies detection, member report generation.

The only known restrictions are and <xs:element minOccurs="0" ...> Also, in RIHA manual https://moodle.ria.ee/mod/page/view.php?id=420, it has been said about subSystemCode suggestions: "The short name may only include lowercase Latin letters (no accented letters), numbers, and the minus sign." but it is not implemented technically nor in RIHA nor in X-Road.

Acceptance criteria

petkivim commented 6 years ago

Transferred to X-Road Service Desk as an enhancement request.