search

vrld / HC

General purpose collision detection library for the use with LÖVE.
http://hc.readthedocs.org/
404 stars 48 forks source link

allow passing segments argument to CircleShape:draw() #65

Closed tesselode closed 2 years ago

tesselode commented 5 years ago

Seems like a feature that was meant to be, but wasn't quite implemented.

pablomayobre commented 5 years ago

This and #63 fix the same thing so it would be worth it to consider which implementation should stay

tesselode commented 5 years ago

Don's PR adds the segments parameter to some outcircle functions as well, which I'm not sure I understand? It just passes the segments argument back. But maybe there's a good motivation I'm not seeing.

pablomayobre commented 5 years ago

I don't think there is honestly, I'd prefer this approach

vrld commented 2 years ago

I like this better, too. Thanks