search

vrld / moonshine

Postprocessing effect repository for LÖVE
553 stars 35 forks source link

vignette has not any effect #20

Closed lynx-seu closed 7 years ago

lynx-seu commented 8 years ago

under mac os x 10.11.5

vrld commented 7 years ago

Hard to reporduce with the given information. Have you tried changing the parameters?

lynx-seu commented 7 years ago

I found that it's ok in a Landscape. However, it doesn't has any effect in a Portrait

vrld commented 7 years ago

Alright, I think I know what is going on: The vignette is computed using the aspect ratio width / height. In landscape, this is > 1 giving the expected result, but in portrait it does not. You can try to play around with the radius parameter (and maybe up the opacity) to see if that changes anything. In any case, I will update the shader to detect whether the format is landscape or portrait.

Good find!