search

vrld / moonshine

Postprocessing effect repository for LÖVE
539 stars 35 forks source link

Fix "scanline_height" key to "line_height" #21

Closed leitdeux closed 6 years ago

leitdeux commented 8 years ago

I resolved a naming conflict in which the key name for "line_height"of the scanlines shader was incorrectly named "scanline_height," resulting in an error thrown in execution. The key has been renamed as "line_height" and thus would be used in Lua as follows:

local scanlines = shine.scanlines()
scanlines.parameter = {pixel_size = 3, opacity = 0.3, center_fade = 0.44, line_height = 0.35}
pyrareae commented 8 years ago

lol, I just added a new pull request for the same thing without realizing this was here.

GeorgeProsser commented 7 years ago

Literally just did the exact same thing as @lunarfyre7

vrld commented 6 years ago

Closing without merging as this will be eventually be fixed in the shinier-api branch