vrld / moonshine

Postprocessing effect repository for LÖVE
538 stars 35 forks source link

shaders compile errors #39

Open azoyan opened 6 years ago

azoyan commented 6 years ago
  1. Xiaomi Redmi Note 3 Pro (Android 6.0.1, Qualcomm Snapdragon 650 MSM8956 1800 MHz, Adreno 510) effect godsray
    
    Error
    Cannot compile pixel shader code:
    Line 15: ERROR: '<': wrong operand types no operation '<' exists that takes a left-hand operand of type 'int' and a right operand of type 'uniform float' (or there is no acceptable conversion)

Traceback [C]: in function 'newShader' moonshine/godsray.lua:62: in function 'e' moonshine/init.lua:81: in function 'moonshine'


2. Cube Talk 9x 16Gb (Android 4.4, MediaTek MT8392 2000 MHz, Cortex-A7, Mali-450 MP4)
effect **vignette**

Error Cannot compile pixel shader code: 0:11: L0001: Excpected token 'i', found 'identifier' 0:12: L0002: Undeclared variable 'v'

Traceback [C]: in function 'newShader' moonshine/vignette/lua:32: in function 'e' moonshine/init.lua:81: in function 'moonshine'


This is not 100% coverage testing, just what i find.
vrld commented 6 years ago

I can guess the fix for the first one, but as for the second issue I have no clue. Unfortunately I do not have the hardware to test this myself. Leaving this open in case anybody that does wants to help close it.