search

vrm-c / vrm-specification

vrm specification
235 stars 37 forks source link

[1.0] Change shading factors which affect to outline lighting mix #392

Closed 0b5vr closed 2 years ago

0b5vr commented 2 years ago

Depends on #382

Description

MToonのOutline Lighting Mixに対して影響するファクタを変更しました。

現状でも、UniVRM・three-vrmで両者は挙動が異なり、そこをUniVRM側に合わせる形の変更となります。

See: https://github.com/Santarh/MToon/blob/f451d61513b137e8e39338d328ffca73d8744f0a/MToon/Resources/Shaders/MToonCore.cginc See: https://github.com/pixiv/three-vrm/blob/5c89224f06b8c703ac81c9a1af4e15f3eee1b0c2/packages/three-vrm-materials-mtoon/src/shaders/mtoon.frag

382 がマージされるまで、以下のURLがdiffが見やすいと思います:

https://github.com/0b5vr/vrm-specification/compare/wip-mtoon-english...0b5vr:vrm-specification:outline-lighting-mix

Description

Santarh commented 2 years ago

ちなみに UniVRM の 1.0 の実装はこちらですね

https://github.com/vrm-c/UniVRM/blob/master/Assets/VRMShaders/VRM10/MToon10/Resources/VRM10/vrmc_materials_mtoon_lighting_mtoon.hlsl#L179