search

vrm-c / vrm-specification

vrm specification
235 stars 37 forks source link

Fixed code error in README.md #467

Closed MalekiRe closed 4 months ago

MalekiRe commented 5 months ago

Pseudocode had an error of localRotation being used in stiffness calculation.

0b5vr commented 5 months ago

LocalRotation exists in the original SpringBone implementation. However, it seems that it should be the initial local rotation instead of the current local rotation.

https://github.com/vrm-c/UniVRM/blob/469c973a0458f8c937c7392a9985df9f9e66d280/Assets/VRM/Runtime/SpringBone/VRMSpringBone.cs#L108

I think we should use initialLocalRotation, which is already defined, instead of localRotation.

Also, would you also fix the README.ja.md?

0b5vr commented 4 months ago

@MalekiRe Ping, do you have time to do this?

0b5vr commented 4 months ago

Closing the PR due to long inactivity. I will make the change instead. Thank you for the proposal!