vrotaru / btcticker

Bitcoin exchange rates as image tickers
9 stars 3 forks source link

Dependent on deprecated API? #1

Closed TheButterZone closed 11 years ago

TheButterZone commented 11 years ago

I swear I remember MagicalTux saying the v0 API might be discontinued.

crazybitcoinguy commented 11 years ago

Looks like the api is depricated as of today. he is using https://mtgox.com/api/0/data/ticker.php You can still access the depricated api here: https://data.mtgox.com/api/0/data/ticker.php

I tried updating in MtgoxTickerV0.ragel and .java but it appears he must be expecting the message on the first line. If vrotaru doesn't fix, I may look at it tomorrow.

TheButterZone commented 11 years ago

Great, thanks. I personally have probably a hundred of those USD>BTC img tags, and had spread the site far and wide. Hopefully the new API can just be swapped in and all the end user's URLs don't need to be reset.

vrotaru commented 11 years ago

Well, this is unfortunate. I'll look into it in this evening. I'll fix it to take into account the warning than, I'll switch to the non-deprecated API

crazybitcoinguy commented 11 years ago

Excellent! Wasn't sure if you were active anymore. Make sure to post your BTC address and I'll donate when you update.

vrotaru commented 11 years ago

I've added a temporary fix and it works now. Over the weekend I'm planning to switch the new API, then I will close the issue.

1FLp5u9RLn4DaEH6ap7rmCCBA1sE6M7NTV (as requested)

crazybitcoinguy commented 11 years ago

Donation made, thanks! Any chance you may add font type/size/color and background parameters? Maybe an option to remove the bitcoin picture? Perhaps different exchange APIs? Anyways, thanks for fixing so quick!

vrotaru commented 11 years ago

You can already remove the picture with a bit of CSS, Different fonts unfortunately are not (easily) possible as long this is hosted on Google AppEngine.

I guess I can add an option to remove the background/make in transparent. Size would be rather easy, but the results would not be necessarily pretty. I can try it though.. Colors are slightly more challenging, but I guess doable.

TheButterZone commented 11 years ago

I might put up a bitcointalk poll or consider changing the default background to be transparent to fit all color schemes. Here's my implementation: http://tbz1.co.nf/?p=211

vrotaru commented 11 years ago

I do not exactly remember why i opted for a background instead of transparency. I'll reconsider it.

vrotaru commented 11 years ago

finally made the switch