vrtmrz / obsidian-livesync

MIT License
3.93k stars 132 forks source link

Notes with quoted strings in their name are synced as if they are deleted #400

Open ikomhoog opened 3 months ago

ikomhoog commented 3 months ago

Abstract

Notes with quoted strings are synced as if they are deleted? for example when making a note for someone with a nickname Dwayne "The Rock" Johnson

Expected behaviour

Actually happened

Reproducing procedure

  1. Make a new note
  2. See that said new note is synced with another device with the name: Untitled
  3. Change the note's name to: Dwayne "The Rock" Johnson
  4. See the note dissapear on the receiving device's end
vrtmrz commented 2 months ago

Thank you for your question! Unfortunately, you are correct. Self-hosted LiveSync only accepts files with problem-free file names on all platforms. " is not allowed on Windows. Therefore, Self-hosted LiveSync has ignored the file as you mentioned.

I keep wondering if there is a better solution. Using an alternative expression only on the specific platform should cause terrible confusion.

ikomhoog commented 2 months ago

I had not thought of actual OS limitations, This type of title would not work for me as I also sync with Windows. I was using a Linux VM at the time which caused the characters to be accepted.

From a user perspective, instead of only preventing errors on the backend, it would be nice to be shown a popup with something along the lines of "File X contains problem character Y" With a button below it to remove the character (could also be a setting to do this automatically), or to have the current non-sync situation and fix it manually.

This could also be extended by showing the platform that the character isn't accepted on, and an option to ignore that platform. I don't use Mac for example and don't care about characters that only Mac cannot handle (if they exist).