search

vrudikov / typescript-rest-boilerplate

Boilerplate project for awesome typescript-rest(https://github.com/thiagobustamante/typescript-rest) library
MIT License
81 stars 46 forks source link

update to use new typescript-rest and typescript-rest-swagger #10

Closed thiagobustamante closed 5 years ago

vrudikov commented 5 years ago

@thiagobustamante i think your branch is kinda outdated?

vrudikov commented 5 years ago

@thiagobustamante now API is broken

vrudikov commented 5 years ago

So you changed Server.buildServices(this.app, ...controllers); to Server.loadServices(this.app, 'controllers/*', __dirname); and it seems it broke controllers

vrudikov commented 5 years ago

Yep. Returned back to Server.buildServices and API works

thiagobustamante commented 5 years ago

Hi @vrudikov, The problem is that you renamed the folder controllers to controller.... and I did not see it during the merge... I created a new PR

vrudikov commented 5 years ago

Oops. Got it

On Thu, Jun 20, 2019, 18:54 Thiago Bustamante notifications@github.com wrote:

Hi @vrudikov https://github.com/vrudikov, The problem is that you renamed the folder controllers to controller.... and I did not observed it during the merge... I created a new PR

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vrudikov/typescript-rest-boilerplate/pull/10?email_source=notifications&email_token=AADYREWZLBLAAHLS7GSFMTLP3OR5FA5CNFSM4HZMCDG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYF24FA#issuecomment-504081940, or mute the thread https://github.com/notifications/unsubscribe-auth/AADYRESFYSVWHPTJBX7G4R3P3OR5FANCNFSM4HZMCDGQ .