vs-form / vs-form-repo

A schema-based form generator component for React using material-ui
7 stars 3 forks source link

migrate material ui to 4x #2

Open ShankzPatil opened 4 years ago

ShankzPatil commented 4 years ago

migrate material ui to 4x https://material-ui.com/guides/migration-v3/

Layout [Grid] In order to support arbitrary spacing values and to remove the need to mentally count by 8, we are changing the spacing API:

/**

if you don't provide spacing by default value set by lib is 16. so it gives warning error.

vs-form commented 4 years ago

Hello @ShankzPatil . I will fix issues and update material-ui next time. Thanks.

ShankzPatil commented 4 years ago

What is ETA for the Material ui 4 because expansion panel is also replaced by accordion. so there are more changes required.

  1. Issue with radio button is show stopper.

  2. react-dom.development.js:89 Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.