search

vs4vijay / golife

Conway's Game of Life Implementation in Ruby
MIT License
2 stars 3 forks source link

Add Unit Tests for Golife Game #1

Open vs4vijay opened 7 years ago

vs4vijay commented 7 years ago

Add Unit Tests for Golife Game

ghwilley commented 7 years ago

I'll work on this!

ghwilley commented 7 years ago

I noticed on the playground generation it starts at 0, so it ends up 11 x 11 due to indexing. Do you want that to stay the same or should I change it to 1 to keep width and height accurate?

vs4vijay commented 7 years ago

@ghwilley : Hey, Thanks for supporting this. Yes, you can work on this. And you can also make the changes in codebase if you find any bugs or improvement.

btw, Which Testing library will you use? I was thinking about TestUnit?

ghwilley commented 7 years ago

@vs4vijay Minitest was already included so I thought I would go ahead on that. I can change it up if you prefer though.

ghwilley commented 7 years ago

I'm sorry if this is just my lack of experience or knowledge, but do I need to be added as a contributor in order to push to the repo? I keep getting 'Permission denied'. (I'm on a feature branch).

vs4vijay commented 7 years ago

@ghwilley Give it a try with Minitest, You have to fork this repo in you profile. Then take clone from it, work on it...and whenever you are ready with your code, Submit Pull Request...