search

vs4vijay / iot-playground

IoT Playground for ESP32, Arduino, M5Stack, and other firmware platforms
MIT License
5 stars 0 forks source link

Add evil cardputer #12

Closed vs4vijay closed 4 months ago

sweep-ai[bot] commented 4 months ago

Sweep: PR Review

Authors of pull request: @vs4vijay

.github/workflows/build_release_firmwares.yml

Replaced Arduino CLI with PlatformIO for compiling M5Launcher firmware and added a new job for compiling and uploading Evil Cardputer firmware.

Sweep Found These Issues

  • The new job compile_evil_cardputer uses a local package_m5stack_index.json file for installing the platform, which may not be available or up-to-date, leading to potential build failures.
    • https://github.com/vs4vijay/iot-playground/blob/81e4bf1b55827352615030e8f4562323021b7e7d/.github%2Fworkflows%2Fbuild_release_firmwares.yml#L684-L688 [View Diff](https://github.com/vs4vijay/iot-playground/pull/12/files#diff-4d1c523b026aa40bfbbe0775bfa89da7a52ff6fabd28e58107f9e0733d666848R684-R688)
.gitmodules

Added a new submodule "Evil-M5Core2" to the .gitmodules configuration.