Closed GoogleCodeExporter closed 8 years ago
Is there anything I can do to increase the chances of inclusion of this patch?
Write some unit tests maybe?
Original comment by benjamin...@uni-siegen.de
on 5 Sep 2011 at 6:58
The code looks fine to me. I don't see any reason not to include it. Still,
Mirko has the final say.
Can I ask why you want this feature?
Original comment by shervin.asgari@gmail.com
on 12 Sep 2011 at 12:31
There are two reasons:
1) It is considered bad practise to branch according to wether an exception
will be thrown or not. However, currently, this was the only way to detect if
connect() worked: by testing if the convert() throws an exception.
2) The library that I am currently building
(https://github.com/benjamin4ruby/java-thumbnailer) tries to fail as early as
possible, thus even before the first convert() takes place.
Original comment by benjamin...@uni-siegen.de
on 15 Sep 2011 at 7:52
Fixed in trunk.
If Mirko objects, he can just revert the code
Original comment by shervin.asgari@gmail.com
on 15 Sep 2011 at 8:07
Original issue reported on code.google.com by
benjamin...@uni-siegen.de
on 16 Aug 2011 at 7:37Attachments: